Hello every one, we would like to submit you a new version of sonaricode we have developed for SonarQube. Here come required information:
Description:
SonarQube i-Code CNES plugin adds the ability to import i-Code CNES results for Fortran (77 & 90) & Shell into SonarQube. i-Code CNES is an open source analysis tool which both checks rules and measure metrics on three languages : Shell, Fortran 77 & Fortran 90. This plugin embeds and executes i-Code CNES checks without any dependencies.
I see that you’ve created a PR, but also that the release isn’t ‘final’
I’m not sure what kind of agreement you’re looking for. None needed on my side (other than that your QG is green and the PR is good). So let me know when it’s final & I’ll move on your PR (which BTW I see now needs some changes. Review coming in a min…)
I approved & merged your PR, but the generation job failed. You changed your plugin key & the plugin key must correspond to the name of the file.
Normally I would tell you to change the plugin key back because the Marketplace won’t be able to manage giving upgrade advice across multiple plugin keys. And I do feel that that’s the best solution. However, if you’d like to retain your new plugin key, I guess it would be okay since you’ve been out of the Marketplace (incompatible) for a while so folks on current SQ versions likely don’t have an old version of the plugin installed.
The plugin key published in the manifest of the jar listed in your PR is soanricode. This does not match the name of the update center properties file, icode.properties.
I’m not quite sure what happened, but version 1.1.0 publishes a manifest that says:
Plugin-Key: icode
It appears that 6 months ago you added <sonar.pluginKey>sonaricode</sonar.pluginKey> to your pom. Now, version 2.0.0 publishes a manifest that says
Plugin-Key: sonaricode
As I said before, the plugin key and the file name must match. Because you’ve been out of the marketplace for a while now, changing either one to match the other is acceptable. However, I suggest you choose to put out a version 2.0.1 with a corrected plugin key and update your PR accordingly.
I’ve merged your PR. Because of some ongoing internal infrastructure changes, I haven’t re-run the job to update the Marketplace yet. I expect to be able to do that tomorrow. In the meantime, I made some comments on your PR. They were optional for this release, but this is a great opportunity for you to make changes and submit a new PR.