[NEW RELEASE] Crowd 2.1.3 (SQ 7.9+ support)

deepy · July 17, 2019, 12:35pm

This contains a community-sponsored fix for the JAXB issues.

It solves the following issue: https://github.com/deepy/sonar-crowd/issues/25
by juggling the classloaders here: https://github.com/deepy/sonar-crowd/commit/020274b7d9242ea0db7715407d9bf88c96b2110c#diff-eec9a2047ceaa281e6db094b220fb518R58

I’m not overly happy with that workaround, so if anyone knows the proper way to do it I’d love a pointer or a PR

Colin · July 17, 2019, 12:52pm

It looks like this is done in the SonarQube codebase at least once so… you get a pass I think

github.com

SonarSource/sonarqube/blob/03bb045cca26245804592602c7ff0c6e477f3b8d/server/sonar-server-common/src/main/java/org/sonar/server/notification/email/EmailNotificationChannel.java#L227


      
              send(emailMessage);
              return true;
            } catch (EmailException e) {
              LOG.error("Unable to send email", e);
              return false;
            }
          }
          
          private void send(EmailMessage emailMessage) throws EmailException {
            // Trick to correctly initialize javax.mail library
            ClassLoader classloader = Thread.currentThread().getContextClassLoader();
            Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
          
            try {
              LOG.trace("Sending email: {}", emailMessage);
              String host = resolveHost();
          
              Email email = createEmailWithMessage(emailMessage);
              setHeaders(email, emailMessage, host);
              setConnectionDetails(email);
              setToAndFrom(email, emailMessage);

ganncamp · July 17, 2019, 3:01pm

Hi @deepy,

Is this your request to have the Marketplace updated? If so, I need you to submit a PR on the repository that holds the underlying data files (and include its URL in this thread )

Ann

ganncamp · July 17, 2019, 3:04pm

Hi again,

Nevermind. Colin pointed out that it’s already in there. Since he’s on this, I’m going to bow out.

Ann

Colin · July 18, 2019, 9:49am

Marketplace updated.