As you can see, the first issue has the “open” button with a chevron, and the second issue does not have the chevron, and is not clickable. There our PR is blocked and cannot be merged.
Is it because the issue was imported with an external analyser, in our case Detekt? Is there a way to also ignore issues from external analysers?
It’s true that external issues can’t be marked false-positive/wont-fix in SonarCloud – we suggest marking them as False Positive / Won’t Fix in the source tool.
Are you using the Scanner for Gradle? I would guess you’re affected by this change which automatically configures the report path.
There’s no graceful way to turn it off (and I’ll flag this for attention as a result) – and, can you tell us why you produce these reports but don’t want them imported to SonarCloud? I’d be really curious to know.
Yes we are using Scanner for Gradle. But configured it to include Detekt on purpose. We are not affected by the change you mentioned.
We have a really old codebase that has some tech debt. We configured to run Sonar + included Detekt. Sometimes we have to change an old file. Editing this file will trigger an analysis of this file and “old” issues will appear. If you change one single line in this file, but the file has many issues detected, you can end up in cases where the “Tech debt ratio” is too high, and the quality gate is bad, and the PR is blocked. Even though you did not touch the majority of the file, the quality gate is bad.
In such cases, we would like to keep the issue as this is a real issue, but we don’t want to be prevented to merge.
Does my use case make sense?
Alright, thanks to your latest reply I dug a bit deeper and realized that the issue itself was not present before. Our change did trigger a new issue from Detekt, that was passed to Sonar.
But this does not change my initial problem. Our “simple” change added a new method in the class, which triggered a “method count” error from Detekt:
Class ‘XXX’ with ‘11’ functions detected. Defined threshold inside classes is set to ‘11’
(Don’t ask me why the default value of Detekt is 11. We’re just in the infancy of using it)
Therefore we are left with two choices:
Refactor the whole file so that the Detekt errors is “correctly” removed
Admit that this is an issue caused by current tech debt, and mark the issue in Sonar as “won’t fix” for now.
Option 1 is not an option in the context of the Pull Request, and Option 2 does not work in Sonar.
I guess this is something Sonar cannot help with (apart from letting us resolve external issues) so we will have to deal with it otherwise.
