Notification API

SonarQube for IDE Eclipse
1

Hi,

it looks to me that the latest Sonar Lint for Eclipse uses the Mylyn API for notifications (as identifiable by the ugly x in the closing menu. To leverage the icon updates from platform (including the move to svg icons in the recent release) it would be nice if you could move the the JFace API eclipse.platform.ui/docs/JFaceSnippets.md at master · eclipse-platform/eclipse.platform.ui · GitHub

This API was migrate from Mylyn multiple years ago and we tried to allow a smooth migrate by providing the same API at the time of migration.

1 Like
2

Hey @vogella,

This is the base class for all SonarQube for Eclipse related notifications shown in the bottom right corner.

It is definitely not using the Notification API as it seems but I also don’t see the reference to Mylyn here :face_with_diagonal_mouth:
The plug-in is build against the latest Eclipse IDE with Java 11, 4.24 (2022-06), for compatibility with older versions and third-party applications build on-top of the Eclipse IDE.
Does this already feature the changes for the JFace API? It will definitely not yet feature the SVG changes if I’m not mistaken.

Cheers :wine_glass:

1 Like
3

Looks like you also made a copy of the Mylyn API. :slight_smile:

The JFace notification (as a port of the Mylyn API) is avaialable since 2020-04-29 see Bug 229823. If you use it, it would use the new images from the corresponding platform, e.g. on the latest Eclipse release, the latest images, see eclipse.platform.ui/bundles/org.eclipse.jface.notifications/icons/eview16 at master · eclipse-platform/eclipse.platform.ui · GitHub

Older releases (with the same API) would use the old png file.

1 Like
6

Hi Lars,

Thanks for reaching out. I created this ticket to migrate to the “new” :upside_down_face: JFace APIs.

Given our current priorities, we probably won’t work on it in the near future.

Cheers!

1 Like
8

Hello,

After a bit more investigation, it appears that we won’t be able to migrate yet. The new API makes the notification appear in the middle of the screen. We would need to use NotificationPopup.forShell that was introduced at the end of 2023, but we still need to support older versions. Some context in this GitHub issue, in which you were involved @vogella

We will keep this ticket for later, in a couple of years :slight_smile:

1 Like