False positive for S2589

um78 · April 24, 2024, 2:24pm

Hi there,
trying out Solarlint i found an FP for S2589.
Found similar issues in the forum but either not exactly same or supposed to be resolved in the plugin version i am using.

Operating system: Windows 10 22H2
Visual Studio version: VS 2022, 17.9.5
SonarLint plugin version: 7.8.0.88494
Programming language you’re coding in: C#
Is connected mode used: No
- Connected to SonarCloud or SonarQube (and which version):

Following code block produces S2589 at line “if (!found)”:

if (licenseData != null && licenseData.Any())
{
    var found = false;
    licenseData.ToList().ForEach(license =>
    {
        if (license.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries).Exists(a => a == artifactType))
        {
            found = true;
        }
    });

    if (!found)
    {
        _logger.LogWarning("No License for artifact type");
    }

    return found;
}

Martin_Strecker · April 25, 2024, 9:55am

Hello @um78,

Thank you for reporting the false positive. I was able to reproduce it and added it to our backlog. To receive further updates, you can track this issue at

github.com/SonarSource/sonar-dotnet

Fix FP S2589: Assignment for captures are ignored

opened 09:50AM - 25 Apr 24 UTC

martin-strecker-sonarsource

Type: False Positive Area: CFG/SE Area: C#

Originally reported at https://community.sonarsource.com/t/false-positive-for-s2…589/114185 ### Description Any mutation of a captured variable is ignored. This applies to captures by delegates and by local functions. ### Repro steps ```cs public bool ForEachTest(List<string> licenseData) { var found = false; licenseData.ForEach(license => found = true); // Assignment in "ForEach" if (!found) // Noncompliant FP { Console.WriteLine("No License for artifact type"); } return found; } public bool SelectTest(List<string> licenseData) { var found = false; licenseData.Select(license => found = true).Any(); // Assignment in "Select" if (!found) // Noncompliant FP { Console.WriteLine("No License for artifact type"); } return found; } public bool ActionTest() { var found = false; Action assign = () => found = true; // Assignment in some delegate assign(); if (!found) // Noncompliant FP { Console.WriteLine("No License for artifact type"); } return found; } public bool LocalFunctionTest() { var found = false; Assign(); if (!found) // Noncompliant FP { Console.WriteLine("No License for artifact type"); } return found; void Assign() => found = true; // Assignment in local function } ``` ### Expected behavior Do not raise on mutated captured variables or learn inside the delegate/local function body. ### Actual behavior FP for S2589 ### Known workarounds Do not mutate capture variables. ### Related information * C#/VB.NET Plugins version * Visual Studio version * MSBuild / dotnet version * SonarScanner for .NET version (if used) * Operating System

um78 · April 25, 2024, 10:22am

Hi Martin,

Thanks for your quick reaction.

Cheers,

Ueli

~WRD0000.jpg