False Positive S2583

[mjconrad]

Make sure to read this post before raising a thread here:

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t…

Then tell us:

• What language is this for? CSharp
• Which rule? S2583
• Why do you believe it’s a false-positive/false-negative? Analyzer is missing that there is a lambda which could assign a value to e below.
• Are you using
  • SonarCloud? No
  • SonarQube - which version? No
  • SonarLint - which IDE/version? Nuget: SonarAnalyzer.CSharp Version="9.17.0.82934
    • in connected mode with SonarQube or SonarCloud? No
• How can we reproduce the problem? Give us a self-contained snippet of code (formatted text, no screenshots)

                    Error? e = null;
                    deleteInfo.Switch(
                            info => doStuff(info),
                            err => e = err);

                    if (e is not null) // False positive here.
                    {
                        return e;
                    }

[zsolt.kolbay]

Hi @mjconrad. This is a known False Positive. The S2583 rule uses our Symbolic Execution engine, which doesn’t track calls to lambdas when it analyzes a method. This is a major feature we plan to implement in the future, but we don’t have a timeline for it yet.