Unused local variables should be removed and min()/max()

Clean Code Report False-positive / False-negative...
,
1

Hi!

Python scanner (4.7.0.2747) detects unused local variables accumulated with operators like +=, but failed on variables accumulated with min()/max() (or may be other functions without side effects):

max_value = 0.0
avg_value = 0.0
for value_tag in value_tags:
     value = get_value(value_tag) # arbitrary source of data
     max_value = max(max_value, value)
     avg_value += voltage
2

Hey there.

Are you using SonarCloud or SonarQube (if the latter, what version?)

3

Hi, Colin!

We use SonarQube Developer Edition Version 9.4 (build 54424).

7

Hi!

Sorry for the very late answer.

You’re right, we could improve the rule to catch such cases.
I created SONARPY-1062 to track this improvement.

Thanks a lot for your suggestion!

8

Hi, Pierre-Yves!

Thank you for help!

10

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.