Two false positives about the rule RSPEC-2974

Rules and Languages Report False-positive / False-negative...
,
1

Hi, I found two false positives about the rule RSPEC-2974, see the code below. SonarQube should not report a warning because the annotation @NoArgsConstructor and @AllArgsConstructor can generate a new public constructor in the class. Hence, I think they are false positive.

import lombok.NoArgsConstructor;
@NoArgsConstructor
public class C {
  private C() {
    // ...
  }

  public static int magic(){
    return 42;
  }
}

import lombok.AllArgsConstructor;
@AllArgsConstructor
public class C {
  private C() {
    // ...
  }

  public static int magic(){
    return 42;
  }
}
2

Hi,

What version of SonarQube are you on? You can find it in the page footer if you’re not sure.

 
Ann

3

Hi Ann, I use SonarQube 9.2.3.

4

Hi,

Would you mind upgrading to the latest version, 9.7.1 (9.8 is due on Monday…) to see if you can replicate the FPs there, please?

 
Thx!
Ann

5

Hello, I have met the same problem by using Sonarqube 9.7.1. The original case has a minor grammar issue. Here are my testcases. :blush:

import lombok.AllArgsConstructor;
@AllArgsConstructor
public class B {
    private B(int a){

    }
    public static int magic(){
        return 42;
    }
}

import lombok.NoArgsConstructor;
@NoArgsConstructor
public class C {
    private C(int a){

    }
    public static int magic(){
        return 42;
    }
}
6

Hi @LynnBroe,

Welcome to the community!

SonarQube 9.7 is already past EOL. You should upgrade to either the latest version or the current LTS at your earliest convenience. Your upgrade path is:

9.7 → 9.9.1 → 10.2 (last step optional)

You may find these resources helpful:

If you have questions about upgrading, feel free to open a new thread for that here.

If your error persists after upgrade, please come back to us.

 
HTH,
Ann

7

Hi, Sonarqube 10.2.0 still has the same problem, and I have tested in the latest version. :blush:

1 Like
9

Hi,

Congrats on your upgrade and thanks for retesting.

I’ve flagged this for the language experts.

 
:smiley:
Ann

11

Hi Belle and LynnBroe,

thanks for your report! You are right, since these classes actually have public constructors in their bytecode representation, the rule should make an exception if a class is annotated with lombok.NoArgsConstructor or lombok.AllArgsConstructor.

I created a ticket here to fix that.

Cheers,
Marco