Remove S4261 from the Sonar Way profile and also remove its DEPRECATED status

The handling of this rule by marking it as deprecated was inappropriate. The reason given was because some customers found it noisy or didnt like it.

The rule is there because there is official guidance from MSFT that has been published for > 10 years recommending it.

If this was a problem for customers who did not want to adhere to the guidance they could just deactivate the rule.

If enough customers complained about the rule, SonarSource could have removed it from the sonar way profile.

Instead it was marked as deprecated, which is a status that is shown to every user of a quality profile by highlighting the QP as a big red failure.

image

This immediately puts into question the validity of the quality profile. Why should programmers trust that their code is being evaluated correctly when the evaluation rules are marked as having some kind of problem? They shouldn’t, and don’t - which can undo any progress made in trying to get an enterprise codebase up to snuff. Please address this by following the advice in the title, or at least stop undermining the adoption and usage of Sonarcloud and remove all the deprecation highlights visible to all users.

Hello Andrew

I am a bit confused why you say this is in SonarWay, because I just checked on :sonarcloud: and it’s not part of SonarWay.

There is not deprecated rule in SonarWay for C# (I looked here).
image

If your org view of the SonarWay profile has deprecated rules, there’s something to investigate on our side…

@Andrei_Epure -

would have been clearer as “could have just removed it”

its not that its deprecated and in sonar way, its that it was marked as deprecated instead of just removing it from the sonar way.

The sonar quality profile that we have refined to best match our coding standards has this rule and even though its a legitimate, applicable, and usable rule the quality profile is displayed on all screens and to all users as if it has a problem.

Hi @StingyJack - we agree with you and decided to revert our deprecation decision (un-deprecate it) and keep the rule out of the SonarWay default profile. Make S4261 active again (revert deprecation) and keep it out of the SonarWay default profile · Issue #4059 · SonarSource/sonar-dotnet · GitHub

Thanks,
Andrei

Thank you for choosing the sensible, logical action.

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.