The PR branches which tell you instantly whether code to be merged passes the quality gate is an awesome thing and greatly helps us time-wise with conducting code reviews. However it only applies to bugs, vulnerabilities and code smells, whereas our quality gate takes into account code coverage and…

Hi, This was delivered in 7.4. [image] SonarQube 7.4 Released Releases Hi all, :confetti_ball:SonarSource is proud to announce the release of SonarQube 7.4 today!confetti_ball You can find the details of the most compelling new features in the official announcement . I…

[image] max: Are you saying the coverage is being taken in consideration to mark the branch/pr analysis quality gate as failed/pass on sonar cloud? I can’t see any change like that yet. You’re right, coverage is calculated but doesn’t yet affect a PR’s status. Why? Well, what’s enough? Your a…

Yes, having the quality gates integrated into the branch/pr analysis is the ideal, we looking forwarding for that, hope it will be ready soon. =) Thanks Ann.

I would expect it to be based on the rules set in your quality gate, so for us I would expect the quality gate to fail if the estimated code coverage is less than 80% for the leak period. Could you also explain what the difference is between the two icons at the top of the PR? As far as I assume, …

Hey Peter, I do have to ask (and apologies if you did already): did you hover the small question marks next to the number ? :stuck_out_tongue: We’ve put them here precisely to help with the understanding. [image] pconnor: As far as I assume, the left stat is what the total coverage will be on …

Yes I read them, the left one is fine it was just more the right one I was having issue with. Everywhere else on the site the peach coloured boxes are all related to leak periods (our leak period is ‘previous_version’), so this implies that would be the overall estimate for the leak period, which i…

Would be nice if we could have the lines marked in the pr as well, just like they are marked when looking the code in sonar (red/green) based in the coverage, i have seen other tools doing that on github, so i think its possible somehow.

Awesome that this is making it’s way into Sonar. I am just wondering, the issue in JIRA is marked as Closed, does that mean that we should be seeing this in SonarCloud? I’m asking because we still see “lines to cover 0” on new code in our PR’s and short lived branches.

Hi, Where are you seeing “lines to cover” on a PR? If you’re seeing it on the PR’s measures page, then you’re demonstrably already using the feature the the question to answer is why you’re getting zeros. Here’s a PR on a public project picked pretty much at random that shows coverage in the heade…

Hi Ann, below is a screenshot where I would expect there to be more uncovered lines. It’s an entirely new class. When I open the class, I correctly see the red indicators that the code is not covered. But none of the lines are colored yellow/orange to indicate that it is new code, which is the case …

Hi, Your header shows 39% coverage, so the value is calculated. The question is why it’s not shown in the UI for you. At this point, I’d advise you to create a new thread include in it any errors in your browser’s developer console. Ann

Pull request branches to include code coverage

Suggest new features

ganncamp (G Ann Campbell) November 8, 2018, 3:57pm 22

Hi,

This was delivered in 7.4.

Ann

Topic		Replies	Views
Block Pull request based on Quality gate code coverage on new code SonarQube Server / Community Build coverage , quality-gate , new-code	17	2790	September 6, 2022
Use overall code coverage conditions as quality gate on Pull Requests Suggest new features sonarqube , coverage , android , bitrise	21	3285	May 10, 2026
Scans of new-style branches no longer fail quality gates SonarQube Server / Community Build sonarqube , scanner	21	3001	August 18, 2023
Coverage is not visible for the feature branches SonarQube Server / Community Build sonarqube , coverage , quality-gate	8	876	September 20, 2022
Approach to incrementally improve quality by Quality Gate on PR branches SonarQube Cloud cfamily , coverage , quality-gate	7	369	July 3, 2024

Pull request branches to include code coverage

Related topics