[NEW PLUGIN] ecoCode JavaScript - Requesting inclusion in SonarQube Marketplace

[ganncamp (G Ann Campbell)]

Hi Maxime,

The bureaucratic requirements are met.

The testing looks good as well, so I’m going to process your PR. Just a few notes:

• Love this (ecocode-javascript:EC9):
  
  And BTW, I’ve already provided feedback internally about the table cell vertical alignment.

Optional

• It looks like all your rules have been classed as Consistency/Conventional in the new Clean Code taxonomy. I’m (now) assuming that’s the default. Just a note that in future releases you may want to take a look at this.

• One thing I’m not seeing is // Noncompliant comments in your noncompliant code samples. They help users separate the wheat from the chaff

• ecocode-javascript:EC24 - I’m surprised this rule recommends a limit and not a where clause. I would think limiting CPU at the server / DB would be in scope here

• I see that a few rules provide Further Reading, which is awesome. And there’s a way to mark that up to have it shown on a ‘More Info’ tab, E.G.. I’m not aware of the details, but if you want to create a thread, we can get it tracked down.

• ecocode-javascript:EC12 - “There are more than two style assignations for ‘element’. Use a class instead.” That doesn’t mean what you think it does.

  assignation
  noun
  plural noun: assignations
  an appointment to meet someone in secret, typically one made by lovers.

  You want “assignments”

 
Ann