New lines to cover shows less lines after merging feature to develop branch

SonarQube Server / Community Build
1

Must-share information (formatted with Markdown):

  • SonarQube Enterprise 7.9.1, SonarQube Scanner 3.3.0.1492
  • SonarQube analysis is done on a feature branch and it showed 104 new lines to cover, which met our quality gate requirement of 85% coverage on new code.
    image
    image1084×349 63.6 KB

After merging to develop branch and triggered the analysis, it shows only 9 new lines to cover instead of 104 new lines as in feature branch, and because of this our quality gate requirement is failing.

image
image1070×396 57.5 KB

2

Hi,

I’m struck by the fact that the list of files in the branch is longer than the list of files in develop. Do those other 2 files still exist in develop?

 
Ann

3

Yes, I can confirm that they exist in develop after feature branch is merged.

6

Hi,
The criteria for “new lines” is different between ‘develop’ and the P/R. In the P/R, the diff is given by git. In ‘develop’, the changed date of each line (normally as provided by git) is compared with the start date of the New Code Period, which in your case is the time date when SQ detected the version ‘5936’.
Does that help understand what’s going on?

7

@dmeneses, So here are we saying if a PR has changed lines which are older than version 5936, those lines wont be considered as new lines to cover ?

8

That’s correct.

9

@dmeneses, in order to overcome this issue we tried git rebase so that older lines commits in the feature branch are treated to be new ahead of develop branch commits.

Base version on develop branch is 6044.
Ran the analysis on the feature branch and it shows 29 new lines to cover of which 26 are in home.component.ts

image
image1560×758 51.6 KB

Then after merging and running analysis on the develop branch, it shows 35 new lines to cover of which 32 are in home.component.ts
image
image1516×769 69.8 KB

The discrepancy I see only in home.component.ts where PR/feature branch is showing 4 “Uncovered Lines on New Code” and develop branch is showing 11 for the same. It has 4 uncovered conditions also. This is impacting coverage in develop branch. Trying to understand why it added previous uncovered lines and conditions as new lines.

10

@arohithr8 If you go to Measures and click on “new lines” and navigate to one of the source code files, you can click on the bar on the left and see what information got loaded from the SCM, including the date and the revision. If this date (or the author date of the revision) is before the start of the New Code Period (in your case, when SQ detected 6044), the line won’t be “new”.

Note that a rebase might change the commit date but won’t typically change the author date and git’s blame relies on the author date.

image