How to suppress javascript:S3504 in a JavaScript file

Rules and Languages Report False-positive / False-negative...
,
1

I’m using SonarQube Developer EditionVersion 9.6.1 (build 59531) in a Docker container
and am scanning a JavaScript file.
In this file, I have a variable declaration as follows:

var showBrowserButtonNavigationWarning = true;

and it is being used in some functions:

function allowBrowserButtonNavigation(event) {
    showBrowserButtonNavigationWarning = false;
}

function blockBrowserButtonNavigation() {
    showBrowserButtonNavigationWarning = true;
}

SQ reports a violation of rule javascript:S3504
But in this location it should be a var.
I tried to suppress this rule by adding the lines:
@ SuppressWarnings(“javascript:S3504”)
// 3504: Unexpected var, use let or const instead.

and the line:
//noinspection SonarLint/javascript:S3504

but both are not working.
How can I tell SQ to not report this ‘violation’?

Kind regards,

Rob

2

Hi Rob,

Welcome to the community!

Your version is past EOL. You should upgrade to either the latest version or the current LTS at your earliest convenience. Your upgrade path is:

9.6.1 → 9.9.1 → 10.1 (last step optional)

You may find these resources helpful:

If you have questions about upgrading, feel free to open a new thread for that here.

If your error persists after upgrade, please come back to us.

 
Thx,
Ann

3

Ann,

Thanks for the info. Will check how we can upgrade SQ in our docker environment.
Do you know if upgrading to 10.1 will fix our issue?

Kind regards,

Rob

4

Hi Rob,

I don’t know. What I do know is that you’re on an unsupported version.

 
:sweat_smile:
Ann

5

Well, I have searched for it and I found that there is a missing of JavaScript comment.
You can use this JS comment to surpass the rule.

/* eslint-disable javascript:S3504 */

var showBrowserButtonNavigationWarning = true;

function allowBrowserButtonNavigation(event) {
    showBrowserButtonNavigationWarning = false;
}

function blockBrowserButtonNavigation() {
    showBrowserButtonNavigationWarning = true;
}

/* eslint-enable javascript:S3504 */  // Optionally, you can enable it again if needed

Let’s try it now to get the result.
Thanks

1 Like
7

Gulshan,

That did the trick.
Tenks!

Regards,

Rob

9

@gulshan212 and @rgouw_om please don’t rely on this behavior as it is undocumented and might be removed in the future.

Sonar provides a dedicated way to mark issues as “Won’t fix” in the UI.

Is there any reason you are not relying on that feature?

12

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.

13

To follow up on Gabriel’s comment. There has to be another reason why the issue disappeared. It’s not possible to suppress the issue using eslint directive:

  1. we disable eslint directives in the analyzer internally, to avoid interference with SonarQube issue management
  2. even if previous point didn’t apply, eslint is not aware of sonar’s rule ids, so it couldn’t work using sonar rule id.

I guess something else must have happened with the project for issue to disappear.