FN on S5863: Compare an object to itself with AssertJ / SoftAssertions

[bzadelhoff (bas van zadelhoff)]

Make sure to read this post before raising a thread here:

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t…

• What language is this for: Java
• Which rule: S5863
• Why do you believe it’s a false-positive/false-negative: SoftAssertions do not show when object is compared to itself
• Are you using
  • SonarQube: 9.9
  • SonarLint: 9.0.0.75308 Intellij 2023.2.2
    • in connected mode with SonarQube
• How can we reproduce the problem:

class JUnit5SoftAssertionsExample {
  
@Test
  void junit5_soft_assertions_example() {
    String testString = "test";
    assertThat(testString).isEqualTo(testString); // shows Assertions should no compare an object to itself message
    assertSoftly(assertSoftly -> {
       assertSoftly.assertThat(testString).isEqualTo(testString); // no message
    });
   SoftAssertions softAssertions = new SoftAssertions();
   softAssertions.assertThat(testString).isEqualTo(testString); // no message
   softAssertions.assertAll();
  }
}