False positives for java:S2259 (NullPointerException) when nullness annotations are used

SonarQube Cloud
,
1

The following snippet raises a false positive of java:S2259:

void foo (Map<String, @Nullable String> map) {
  map.size(); // "A "NullPointerException" could be thrown; "map" is nullable here.
}

Sonar seems to think that the complete map can be null when only it’s values can be null.
Screenshot of a real-world example:

image
image707×193 19.6 KB

2

It seems to affects any generic type where the type parameter allows for null values:

image
image650×260 20 KB

6

Hello @sithmein
Thanks a lot for providing this feedback.

We are reviewing the exact code for the rule (there has been some changes in its code lately), and most probably we will create a ticket to tackle this FP.

I will keep you updated.

14

Hello @sithmein ,

Thanks again for your feedback and sorry for the late reply. I’ve created a ticket in our internal backlog to fix the reported FP.

Will come back here to notify when the fix lands in SonarQube Cloud.