S2259 Null pointers should not be dereferenced: false positive

[sbv (Sven Bovens)]

Version: SonarQube DE 8.9.9 (build 56886) (LTS)

Following code gives 2 false positives for S2259 on responseEntity.getBody().length() with “getBody() can return null”:

    public String testAnd(ResponseEntity<String> responseEntity) {
        if (responseEntity != null && responseEntity.getBody() != null && responseEntity.getBody().length() > 0) {
            return  responseEntity.getBody();
        }

        if (responseEntity == null || responseEntity.getBody() == null || responseEntity.getBody().length() > 0) {
            return null;
        }
        return  responseEntity.getBody();
    }

This issue doesn’t occur in SonarQube CE 7.9.1 (build 27448)

[Quentin (Quentin Jaquier)]

Hello @sbv

I invite you to have a look at this post, answering a similar issue:

[False Positive]A "NullPointerException" could be thrown;

versions used (SonarQube, Scanner, language analyzer) - SonarQube 8.9 Language - Java 8 Failing Rule - A “NullPointerException” could be thrown; minimal code sample to reproduce (with analysis parameter, and potential instructions to compile). try (Connection connection = jdbcTemplate.getDataSource()!=null ? jdbcTemplate.getDataSource().getConnection(): null;){ } This throws an error “A “NullPointerException” could be thrown; “getDataSource()” can return null.”. The null check is already i…

I hope it clarifies the situation.
Best,
Quentin