csharpsquid:S6966 should not be given for DbContext.Add

[DdeM (Dave de Moel)]

While developing using EfCore in an async context I get the following warning from SonarLint “SonarLint: Await AddAsync instead.”

This is a false positive. While the method does exist, Microsoft is very explicit that you should only use that in cases where you use special value generators: DbContext.AddAsync Method (Microsoft.EntityFrameworkCore) | Microsoft Learn

This method is async only to allow special value generators, such as the one used by 'Microsoft.EntityFrameworkCore.Metadata.SqlServerValueGenerationStrategy.SequenceHiLo', to access the database asynchronously. For all other cases the non async method should be used.

As you can’t easily suppress Sonar warning this is very annoying within larger crud applications.

[Colin]

I’ve moved your post to the section on reporting false-positives.

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t…

Can you please update your post with what version(s) of which product(s) you’re using and a code sample that raises the issue?

[DdeM (Dave de Moel)]

JetBrains Rider 2024.1.4
Build #RD-241.18034.76, built on June 23, 2024
org.sonarlint.idea (10.7.0.78874)

Sadly don’t have access to a code sample at this time, but it;s easily reproducable by just having a service using Context.Add instead of Context.AddAsync within an async method.