The Rule of "nested too deeply" - go:S134 have false positive

[_YaleChen (陳越威 YaleChen)]

Must-share information (formatted with Markdown):

• which versions are you using (SonarQube, Scanner, Plugin, and any relevant extension)
  SonarQube 7.7
  Scanner 4.2.0.1873
  SonarGo 1.1.0 (build 1612)
• what are you trying to achieve

I find that The Rule of “nested too deeply” - go:S134 have false positive, and if the rule find “else if”, it will “Nesting +1”.

But the nesting depth has not increased

func demo() {

   if a != nil {

   } else if a != 1 {

   }
}

• what have you tried so far to achieve this

[Quentin (Quentin Jaquier)]

Hello @_YaleChen, thanks for the feedback.

I tested this on a recent version of Go analyzer (1.6.0) and it behaves as expected, the else-if does not increase the nesting.

I would therefore advise you to update SonarQube, or at least update Go analyzer to not face this issue.

Best,
Quentin

[_YaleChen (陳越威 YaleChen)]

Thanks. I will update SonarQube.