Tests using not operator incorrectly identified as not including assertions

[Simon-Leslie]

Make sure to read this post before raising a thread here:

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t. …

Then tell us:

• Typescript
• typescript:S2699 - Tests should include assertions
• Some of our tests have been identified as not containing assertions. They do contain assertions but the use of the not operator makes them appear as invalid. It seems the rule only gets highlighted on test files which happen to import from ‘supertest’, which aligns with the rule description.
• SonarQube Cloud

import request from 'supertest';

describe('app', () => {
  it('does no console logs', async () => {
    jest.spyOn(global.console, 'log');

    await request(app).get('/');

    expect(console.log).not.toHaveBeenCalled();
  });
});

[Colin]

Hey there.

Thanks for the report!

There’s a rather broad ticket here (JS-627) that I think covers what you’ve pointed out is missing here. In any case I’ve linked this thread to that ticket.