squid:S1319 not detecting all issues

SonarQube
,
1

In advance: This is not really a false-positive, rather a false-negative.

Comparing analysis results for the same projects in my old and new environment I’ve detected that the java rule squid:S1319 detect much less in the new environment without apparent reason.

  • Old environment: SonarQube 5.6.7 + sonar-java-plugin-4.15.0.12310
  • New environment: SonarQube 7.9.1 + sonar-java-plugin-5.14.0.18788

The source code of the project and the sonar-project.properties were exactly the same in both analysis.

This issues were correctly detected in old environment:
Sample A:
image
Sample B:

image
image.png983×116 9.56 KB

And, as you can see, in the new environment they were not detected anymore:
Sample A:
image
Sample B:
image
image.png762×135 9.37 KB

In fact, in some projects, the difference in the number of issues detected by the rule can be really significant.
Old environment:

image
image.png302×631 13.1 KB

New environment:
image
image.png309×593 16.4 KB

I could not find a pattern or an apparent reason for the lack of issues. ¿Some help or workaround about it?

2

Hello @irinacen,

First, please note that the two versions have around three years difference, a lot of happen between the two, while we have access to the history (tickets, github, …), taking into account the impact of everything is really hard.

From what I see, the current implementation of the rule should report an issue for the code in your sample, you could try to add a new piece of code (containing an issue), to see if it is correctly reported? If you manage to create a reproducer, can you share it here?
You can also have a closer look in the logs of the analysis, something may not be working as expected (maybe the fact that you keep exactly the same properties for the two analysis is the problem!)

Hope this can lead your research.

Quentin