SonarQube appears to be incorrectly detecting S3655

[DanCorderGds (Dan Corder)]

• ALM used - GitHub
• CI system used - Github Actions + AWS Code Pipelines
• Languages of the repository - Java
• Only if the SonarCloud project is public, the URL - GitHub - govuk-one-login/ipv-core-back
  • Pyic 8250 gpg45 scoring by DanCorderIPV · Pull Request #3146 · govuk-one-login/ipv-core-back · GitHub
• Error observed - Warning S3655 triggered Call "Optional#isPresent()" or "!Optional#isEmpty()" before accessing the value when I believe it to be impossible
  • Line 428 of CheckExistingIdentityHandler.java
  • Lines 461 and 470 of ProcessCandidateIdentityHandler.java
• Steps to reproduce - Remove the SuppressWarning annotation
• Potential workaround - Use SuppressWarning

Screenshot added for context and because I can no longer see the original analysis to copy/paste from it (I didn’t find this forum until after screenshotting it and fixing the issue).

[nelkahn (Daniel Robinson)]

I suspect the analysis tool has no way of knowing that the method votMatchingResult.strongestRequestedMatch() always returns the same object.

I suspect that if you put that in a variable before the isEmpty check and use the same variable for the get() then sonarQube will stop complaining as it will be able to identify that the check has been done on the object.

Kind regards

[DanCorderGds (Dan Corder)]

Thanks, you are correct, adding in local variables has removed the warning