Sonarlint rule java:S2386 not working properly

Clean Code Report False-positive / False-negative...
,
1 
public static final Map<String, ArrayList<Command>> customCommands = new HashMap<>();
public static final Map<String, ArrayList<Command>> coreCommands = new HashMap<>();

I have these two lines in my code. These are fields of a class. Even though they are declared as final, Sonarlint gives a positive for rule java:S2386 "Mutable fields should not be "public static"".

I'm working in Eclipse IDE using JDK 13. Sonarlint's version is 5.0.
2

Even if they were final, the collection itself is still mutable. I believe Sonar would not report an issue if they were wrapped via Collections.unmodifiableMap(), but you would need to adapt your code so that all values are assigned at initialization of the variables.

1 Like
3

Iā€™m using java 11ā€™s Map.ofEntries(entry(), entry()ā€¦);
This utility returns an unmodifiable map, but SonarLint still complains to make it protected

4

@CrushaKRool should I raise new bug ?

6

Hello @saisuryakat,

should I raise new bug ?

Since your problem is targetting another case and the initial question is marked with a solution, the good way to go would indeed be to create a new post. It will help to not go unnoticed for too long.

In this case, no need to create another one, I agree with you and created a ticket thanks to your feedback (SONARJAVA-3429).

Best,
Quentin

1 Like
8

Thank you @Quentin

1 Like