SonarLint: java:S1319 for EnumMap

[rhystedstone]

SonarLint (v2.0.0) tells me to “use collection interfaces” on an EnumMap.
The offending code:

EnumMap<BountyType, Integer> completions

Which displays: “Declarations should use Java collection interfaces such as “List” rather than specific implementation classes such as “LinkedList” (java:S1319)”

Map is not applicable here: It causes a type mismatch (for obvious reasons)

[alban.auzeill]

Hi Rhys,
Where is the type mismatch? Could you provide a reproducer?

[rhystedstone]

Hello, here’s where all of this occurs - with the type mismatch

public BountyBook(Bounties plugin, Player player, Map<Integer, AbstractBounty> bounties, ItemStack book,
            Map<BountyType, Integer> completions, double creditsEarnt, int experienceEarnt) {

        this.plugin = plugin;
        this.player = player;
        this.bounties = bounties;
        this.book = book;
        this.completions = completions;
        this.creditsEarnt = creditsEarnt;
        this.experienceEarnt = experienceEarnt;

        // Initialise the book data
        initialiseBook();

    }

[bduderstadt (Björn Duderstadt)]

Presumably the class field completions is declared as specific type EnumMap<...> as well. If only the type of the constructor parameter completions is changed to Map<...>, there will be a type mismatch, because it cannot be guaranteed that the argument is an EnumMap. The field needs to be a Map, too.