SonarCloud + GitHub + Pull Request Analysis = No Inline Comments

Hello, just wanted to also add that our company was very disappointed when we saw this feature disappear. Even though the conversation tab is meant for humans, by enabling this feature we are asking sonar to provide a “human-like” review of our code. It’s meant to simulate a human, so I would like to see this feature come back. Maybe make it an optional feature which people could enable/disable if it’s controversial with github’s guidelines.

5 Likes

We would also love to have this feature back. It significantly improves code quality & productivity by showing everything there is to a PR to a developer. There’s no way they’ll forget to go through the reported issues.

3 Likes

Registered to say that my team shares the same sentiment: SonarCloud is barely helpful and completely unnoticed without inline comments.

2 Likes

I am currently evaluating code quality tools for my team and I was just about to go with SonarCloud as it matches our code base and security requirements better than Codacy and Code Climate. However, finding that the most useful feature has been removed is incredibly disappointing. I concur with the statements above that 2 workflows are impossible to implement, especially with people who are only occasionally raising PRs.

1 Like

Where are we at with this, SonarCloud team? To be very clear, this is the main issue stopping us from deepening our SonarQube implementation, and will be the #1 reason we will churn off the platform to another product. Inline comments are perfectly fine - please don’t get hung up on the Annotations thing.

This is also important to my team. We are currently a Codacy customer, and find that this feature delivers a lot of value. We would be interested to re-consider SonarCloud if and when this feature is re-enabled.

Hi everyone,

Just to let you know that we’re currently looking at this.
We’re going to provide a way to see SonarCloud issues in diff of GitHub PR, either by annotations or comments.

Thanks!

2 Likes

Annotations or comments are such great feature.
I’m impressed that SonarCloud currently doesn’t support it;

That’s great news! Are you targeting this in a current or far future release?

:tada::tada::tada::tada::tada::tada:

Hi, do you have any estimation when we can have inline comments again? :upside_down_face:

We were evaluating sonarqube developer edition 8.1.0, the main reason for us to move from community editon to developer edition was pull request decoration feature.
So can we know from which version this feature was removed/issue has been started?, so that I can downgrade to that version to get this feature.

Had created issue for the same here.

Will this be added back to SonarQube as well?

Our issue was that if the PR check passed but there were still minor issues that didn’t fail the quality gate, then they would go unnoticed (who’s going to click on the details of a passing PR check?). Therefore our only options were to leave uncaught minor issues unfixed, or change the quality gate to make minor issues a failing condition (which is annoying because there are a lot more false positives).

Hi @dannymartin,

We are currently looking at it for SonarQube (MMF-1892). We plan to bring a sum up as a comment in the conversation tab so that you are aware of the remaining issues even when the quality gate is green.

That’s great news, I wish the inline comments would come back as well but this is definitely better than nothing. Looking forward to seeing it in a future release. In the meantime I’ll be using an old version of SonarQube to get the old PR commenting functionality

1 Like

That’s sort of better than nothing, but still really not what we are looking for, nor what brought us to Sonarqube. Plenty of other products on the market have inline markup at this stage in the game.

3 Likes

To everyone wanting the sonar annotations directly in the PR diffs: There is https://github.com/swingletree-oss/plugin-sonarqube. It does that (and even more).

Are the any hope to get inline comments back?

We don’t plan to bring back inline comments, but we do want to add GitHub annotations at some point. I’ve created SCCOMM-33 to track this.

2 Likes

I am quite bummed to see that you have removed the inline comments . I am not sure as to why this had to be done. . We were able to fix numerous code quality issues as these “inline comments” would stare back at us right through our screens.

I think you killed the most important feature that made us adopt sonarQube. This is a short sighted decision and not well thought of.

.if “Polluting with sonarqube comments” was an issue, Instead of removing this inline comments all together, you could have come up with a toggle button to enable/disable sonarQube comments, with ease of use .
I will recommend to my company to start evaluating other options. Such a disappointing change, this is.

1 Like