S3353 Incomplete compliant sample

Clean Code Report False-positive / False-negative...
,
1

S3353 shows the following compliant solution:

function seek(input) {
  const target = 32;
  for (let i of input) {
    if (i == target) {
      return true;
    }
  }
  return false;
}

function getUrl(query) {  
  const url = "http://example.com";
  return url;
}

S3353 should show the following compliant solution:

function seek(input) {
  const target = 32;
  for (const i of input) {
    if (i == target) {
      return true;
    }
  }
  return false;
}

function getUrl(query) {  
  const url = "http://example.com";
  return url;
}

In the current solution is the const at the for-loop missing, but is detected by the scanner.

2

Hello Robert,

Thank you for pointing out this inconsistency. In that regard, I created this ticket.

Yassin