S2629 False Positive on Java record getter

Rules and Languages Report False-positive / False-negative...
,
1

Windows 10, Eclipse 2023-03, SonarLint 7.10.0.68588, Java 17

Problem: false positive S2629 on Record getters.

Code Example:

public record r(String name) { }
...
log.debug("The name is: {}", r.name());

r.name() is flagged for S2629, but it is essentially a getter for the record.

4

Hello @jeff-tyl,

Thanks for your message. Indeed, this code feels like a valid one, so I created a ticket to fix it:

https://sonarsource.atlassian.net/browse/SONARJAVA-4474

However, there is still a corner case, if the getter is overridden and does some expensive computations. Anyway, I don’t feel like that is a common practice.

Regards,
Margarita

6

I was curious to hear if this is going to be fixed? The issue you created also seems to refer to the wrong rule (should be S2629, not S2628) - RSPEC :slight_smile:

7

Also note that the “it might be overridden” argument would apply in the same way (arguably, even more) to getters and I don’t think Sonar makes any attempt to distinguish trivial getters from getters doing some expensive comutations.