S1905 - False Positives generated within c# ternary operator statement

[garrick_s]

The analyzer generates “warning S1125: Remove the unnecessary Boolean literal(s).” on the line of code for the ‘required’ boolean assignment. In the code snippet below, ‘item’ object is an optional (can be null) ‘to be cloned’ item of DataItem type. Code intent is 'use values from the cloned item, if there is one, otherwise use defaults. ‘titleHtml’ property is of string type (and no warning is generated), ‘required’ is a bool type. Looks like S1905 warning is caused by the first (true) part of the ternary statement, but since 2nd (false) ternary statement is not a ‘true’ literal, the warning really should not be shown.

            var newItem = new Datatem()
            {
                // Skipping code lines ....
                titleHtml = item == null ? string.Empty : item.titleHtml,
                required = item == null ? false : item.required
            };

[costin.zaharia]

Hi @garrick_s,

welcome to our community.

I’ve took a short look and as far as I can tell the solution suggested by the code fix provider required = !(item == null) && item.required respects the rule specifications.

[garrick_s]

Costin - the issue as described is with a false positive on the string assignment line:

@garrick_s

titleHtml = item == null ? string.Empty : item.titleHtml,

[costin.zaharia]

Hi @garrick_s, I think I don’t understand what you mean.

This snapshot is from my attempt to reproduce the issue using the latest version of the analyzer (8.9):

As you can see, the issue is raised on the false token from required = item == null ? false : item.required. line which is a false literal expression.