S1301 false positive when switching over enums with 2 values

[gdoenlen (George)]

If your question is about SonarQube for IDE in the IntelliJ Platform, VS Code, Visual Studio, or Eclipse, please post it in that sub-category.

Otherwise, please provide:

• Operating system: Windows
• IDE name and flavor/env: IntelliJ Ultimate

And a thorough description of the problem / question:

When switching over enums with 2 or less values S1301 will fire and tell you to use if statements. This is a false positive because you want switch exhaustion over enums.

enum Something {
   ONE, TWO
}

var s = ONE;
switch (s) { <-- S1301 here
   case ONE -> ...;
   case TWO -> ...;
}

[tomasz.tylenda]

Hi George,

Thank you for the report! I created a ticket, SONARJAVA-5730, to track this problem.

The rules predates switch expressions (the ones with ->) and they may indeed be more readable than an if statement, so we will discuss how to relax the rule.