Possible false positives on rule Web:UnclosedTagCheck

[ivandalbosco]

Hello,

I think the following issue on a regex in a .php file is a false positive :

$pattern = ‘@(<a\[^>\]+?href=“(\[^”\]*)"\[^>\]*?>(.+?))@i’;

I think the following issue in a .twig template file is also a false positive :

Also, the error message itself is incorrect. The first error message above says:

The tag “a\[^” has no corresponding closing tag

when it should say something like:

The tag “<a>” has no corresponding closing tag

I am using SonarQube Community v26.1.0.118079.

[michal.zgliczynski]

Hi @ivandalbosco,

Thank you for the report. Based on your feedback we have implemented 2 improvements:

• SONARHTML-169 Fix PHP directive closing on end token inside single-quoted strings by zglicz · Pull Request #591 · SonarSource/sonar-html · GitHub
• SONARHTML-169 Fix UnclosedTagCheck false positives in Twig templates by zglicz · Pull Request #589 · SonarSource/sonar-html · GitHub

With the next release of SonarQube both of these should be gracefully handled.

Kind regards,

Michal

[ivandalbosco]

Thank you very much Michal for your quick response.