Here’s a sample comment by a bot on one of the PRs that was created after merging the initial coverage reporting and making it work: Update tests, add more socket and ping tests, re-export a bit more types, add a coverage badge by slvrtrn · Pull Request #256 · ClickHouse/clickhouse-js · GitHub
See that it still shows “- No data about Coverage”. Same in the next PR, where there were more obvious changes to the code base, and not just index.ts or tests.
However, the overall coverage is correctly reported on the main branch and is correctly shown as 94%+ in the Overall code tab.
Is it something that I misconfigured, perhaps?
Here are the related bits:
- clickhouse-js/sonar-project.properties at main · ClickHouse/clickhouse-js · GitHub (yes, the organization, for some reason, is called “clickhouse-java”
) ClickHouse_clickhouse-jsis the correct project key./coverage/lcov.infois the correct LCOV path from NYC. Otherwise, I’d assume it wouldn’t be uploaded from the main branch.- relevant job in the workflow: clickhouse-js/.github/workflows/tests.yml at main · ClickHouse/clickhouse-js · GitHub
Extra tweaks in SonarCloud:
- The new code is set to “previous version”; still no diff even though there were two new versions already (git tags/releases).
- TSConfig path:
tsconfig.all.json(which is in the repo root)
Analysis scope:
- include
**/src/** - exclude
**/client-web/**(this scope is supposed to collect the Node.js package coverage, which resides inpackages/client-node/src/**and usespackages/client-common/src/**and should be included by the previous setting). - test file exclusions:
**/__test__/**
Is there anything obvious I am missing here?
Cheers.