kotlin:S6311 raises a false-positive for Android ViewModel coroutines usage

[jonnyandrewgds (Jonny Andrew)]

Make sure to read this post before raising a thread here:

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t. …

Then tell us:

• Which product: Sonarqube Cloud
• What language is this for? Kotlin
• Which rule? kotlin:S6311
• Why do you believe it’s a false-positive/false-negative? This is idiomatic usage according to official Android documentation: Best practices for coroutines in Android  |  Kotlin  |  Android Developers
• How can we reproduce the problem? Self contained snippet:

class MyViewModel() : ViewModel() {

    private val _actions = MutableSharedFlow<Unit>()
    val actions: Flow<Unit> = _actions

    fun nonSuspendingFunction() {
        viewModelScope.launch {
            _actions.emit(Unit)
        }
    }
}

[egon.okerman]

Hey Jonny,

Thanks for letting us know.

kotlin:S6311 has a bug currently, which causes it to raise an issue in cases such as the snippet you gave. There is a fix underway and it should be corrected by the next release.