javabugs:S2190 false positive

[gtoison (Guillaume Toison)]

Hello,
I see what seems to be a false positive on sonarcloud here: SonarQube Cloud

The relevant code is:

public class InfinitestLogPane extends JPanel {
	
	public InfinitestLogPane(Application application) {
		this(application.getService(IdeaLogService.class));
	}
	
	public InfinitestLogPane(LogService logService) {
		super(new BorderLayout());

The full code is here: infinitest/infinitest-intellij/src/main/java/org/infinitest/intellij/plugin/swingui/InfinitestMainFrame.java at master · infinitest/infinitest · GitHub

It seems that sonar recognizes the 1st constructor as recursive, however it is actually calling the second constructor (so there’s no recursion involved here).

[gtoison (Guillaume Toison)]

Apparently the issue is gone, thanks to whoever looked into it!

[Colin]

Hey @gtoison

We did coincidentally deploy a new version of this rule yesterday with an improvement that was merged a week ago. What a nice coincidence!

Thanks for your report and of course, keep 'em coming if you spot somethign else.

[gtoison (Guillaume Toison)]

ah, I knew I wasn’t completely crazy yet
Thank you!