java:S6857 false positive when using @Value to inject directly into a Map

[theBlackDragon (Bert Geens)]

Make sure to read this post before raising a thread here:

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t…

Then tell us:

• What language is this for? Java
• Which rule? java:S6857 “SpEL expression should have a valid syntax”
• Why do you believe it’s a false-positive/false-negative?
  Syntax working fine for injecting directly into a Map as presented here: https://www.baeldung.com/spring-value-annotation#using-value-with-maps
• Using SonarCloud
• How can we reproduce the problem? Give us a self-contained snippet of code (formatted text, no screenshots)

public class TestConfiguration {
    @Value("#{${valuesMap}}")
    private Map<String, Integer> valuesMap;
}

[Margarita_Nedzelska]

Hello @theBlackDragon,

Thanks for the report. I was able to reproduce the issue, Here is the ticket to fix it: [SONARJAVA-4917] - Jira

Best,
Margarita

[LucasDesenv (Lucas de Souza)]

Hi , we also noticed it happens when the default value is empty it complains of malformed property.
Eg.:

    @Value("${management.metrics.server.excluded-uris:}")
    private List<String> excludedUris;

Where the default would be an empty array by applying the :

[Margarita_Nedzelska]

Thanks @LucasDesenv,

I added another example to the ticket.

Best,
Margarita

[asoldo11 (Antonio Soldo)]

Hi Margarita,

Is there any information about the ticket? Will it be fixed, and if so, when?

[ganncamp (G Ann Campbell)]

Hi @asoldo11,

You can check the ticket in Jira to see its status.

 
HTH,
Ann

[Ville_Mustonen]

Hi,

This also seems to happen when the default value is a list

 @Value("${application.animals:cat,dog}")
 private List<String> animals;

[Dorian_Burihabwa]

Hey @Ville_Mustonen,

Welcome to the community, and thank you for reporting this issue!

I have been unable to reproduce the false-positive with the example you shared.

Could you create a new thread and share a bit more details about which versions of Spring and the products you are using?

This would help us greatly triage and narrow down where the problem is coming from.

Cheers,

Dorian