[Java] S2201 should check certain Collection methods

Rules and Languages New rules / language support
1

The rule S2201 checks whether the return value of a function that is free of side effects is assigned. However, the rule currently only checks certain immutable types and is thus severly limited. In addition to the these types calls to certain Collection methods should also be checked. For example:

Collection.contains(Object)
Collection.containsAll(Collection<?>)
Collection.size()
Collection.isEmpty()

Optionally, the following methods could be considered:

Collection.toArray()
Collection.toArray(T[])
Collection.iterator()
2

Hello @oliver,

Thanks for proposing this, I agree that adding more methods can be a nice improvement to the rule.
Ticket creat: SONARJAVA-3478.

Best,
Quentin

1 Like
3

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.