[java:S2093] FP when handling streams without external access

SonarQube Server / Community Build
, ,
1

Qube: Community 9.9

The Java rule S2093 nicely reminds me to update older code, that didn’t use try-with-resources. but it should not hit when I open a ByteArrayInputStream, ByteArrayOutputStream, StringReader, StringWriter etc.

3

Hi,

I’m not finding a rule S2035. Did you mean S2093?

 
Thx,
Ann

4

Yes, sorry. It is 2093.

5

Oh, and the marker should be placed (at least additionally) to the resource, that needs to be handled. It can be a little hard to find it when the try block is large. Currently the marker is at the next surrounding try, which is random.

1 Like
7

Hi,

Thanks for the confirmation. I’ve flagged this for the language experts.

 
Ann

9

Hello @mfroehlich,

Thanks for your message. Could you, please, share a code example with me? Is it that you’re using try/finally with empty finally or something else?

Best,
Margarita

10

Hey Margarita,

unfortunately I cannot find the examples in our code. But you’re right. It happens with a try/finally. But doesn’t with a try/catch.

try
{
    ByteArrayOutputStream baos = new ByteArrayOutputStream();
    baos.reset();
}
finally
{
    // Do something...
}

When I stumple across one of our live examples, I will post it here.

11

Okay, thanks. Will be waiting for the example.