java:S1948 FP when migrating to jakarta.inject.Inject

renoth · February 17, 2024, 8:06pm

Java
Which rule?
java:S1948
Why do you believe it’s a false-positive/false-negative?

When migrating from javax.inject.Inject to jakarta.inject.Inject the Rule suddenly raises FP for the affected fields.

The rule does not seem to check for jakarta.inject.Inject in any way, even though it did check for javax.inject.Inject.

SonarSource/sonar-java/blob/7cdd1f2940f96df8648add9940f341b3668170da/java-checks/src/main/java/org/sonar/java/checks/serialization/SerializableFieldInSerializableClassCheck.java#L52


      
          import org.sonar.plugins.java.api.tree.Modifier;
          import org.sonar.plugins.java.api.tree.ParameterizedTypeTree;
          import org.sonar.plugins.java.api.tree.Tree;
          import org.sonar.plugins.java.api.tree.TypeTree;
          import org.sonar.plugins.java.api.tree.VariableTree;
          import org.sonar.plugins.java.api.tree.WildcardTree;
          
          @Rule(key = "S1948")
          public class SerializableFieldInSerializableClassCheck extends IssuableSubscriptionVisitor {
          
            private static final String JAVAX_INJECT = "javax.inject.Inject";
            private static final String[] EXCLUDED_ANNOTATIONS = new String[]{
              "jakarta.annotation.Resource",
              "javax.annotation.Resource",
              "javax.ejb.EJB",
              JAVAX_INJECT,
              "org.apache.wicket.spring.injection.annot.SpringBean"
            };
          
            @Override
            public List<Tree.Kind> nodesToVisit() {

Are you using
- SonarQube - which version? 9.9.3
- SonarLint - which IDE/version? IntelliJ 10.2.1.77304
  - in connected mode with SonarQube - yes
How can we reproduce the problem? Give us a self-contained snippet of code (formatted text, no screenshots)

package mypackage;

import jakarta.inject.Inject;

public class MyClass implements Serializable {

	@Inject
	private MyService service;

}

Colin · February 19, 2024, 9:23am

Hey there.

Thanks for the report. We already have an open ticket here: SONARJAVA-4816

renoth · February 20, 2024, 8:03am

I opened a PR Add jakarta.inject.Inject to S1948 by renoth · Pull Request #4674 · SonarSource/sonar-java · GitHub