[Java] Lombok usage can be simplified

Clean Code New rules / language support
,
1

Hello,

I have a suggestion for a new rule.
Lombok provides a convenience annotation @Data which is a shortcut for
@ToString , @EqualsAndHashCode , @Getter, @Setter, and @RequiredArgsConstructor.

Noncompliant Code

@Getter
@Setter
@EqualsAndHashCode
@ToString
@RequiredArgsConstructor // Non-compliant, can be simplified
class Foo {
  // ...
}

Compliant

@Data // Compliant
class Foo {
  // ...
}
  • type : Code Smell
  • Tags: java, lombok, clumsy

References

2

It might also make sense to suggest @Data even when only @Getter, @Setter and @RequiredArgsConstructor are used, however, this is not exactly equivalent since @EqualsAndHashCode and @ToString would be added.

3

I would add that @Value is shorthand for:
final @ToString @EqualsAndHashCode @AllArgsConstructor @FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE) @Getter
Lombok docs

1 Like