Incorrect Node.js version reference in Typescript analysis documentation?

Colin · March 2, 2021, 3:47pm

Hey there.

NodeJS 11 is, unfortunately, specifically a troublemaker (and, for what it’s worth, no longer a supported version). See SonarSource/SonarJS #2496. Looks like you’ve already found this in your research.

So we recently released a bugfix of our Javascript/Typescript analyzer that will make its way into our next SonarQube release – a warning will get logged whenever you’re running on an unsupported version of Node.JS (as of today supported versions are v10, v12, v14 and v15).

github.com

SonarSource/SonarJS/blob/8c01ffad4bf0a82a9da89e747efd5dd18743eb2c/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/NodeDeprecationWarningTest.java#L39


      
          import org.sonar.api.internal.SonarRuntimeImpl;
          import org.sonar.api.utils.Version;
          import org.sonar.api.utils.log.LogTester;
          import org.sonar.api.utils.log.LoggerLevel;
          
          import static org.assertj.core.api.Assertions.assertThat;
          
          public class NodeDeprecationWarningTest {
          
            private static final String MSG = "You are using Node.js version 8, which reached end-of-life. Support for this version will be dropped in future release, please upgrade Node.js to more recent version.";
            private static final String UNSUPPORTED_MSG = "Node.js version 11 is not supported, you might experience issues. Please use a supported version of Node.js [10, 12, 14, 15]";
          
            @Rule
            public final LogTester logTester = new LogTester();
          
            @Test
            public void test() {
              SonarRuntime sonarRuntime = SonarRuntimeImpl.forSonarQube(Version.create(8, 5), SonarQubeSide.SCANNER, SonarEdition.COMMUNITY);
              List<String> warnings = new ArrayList<>();
              NodeDeprecationWarning deprecationWarning = new NodeDeprecationWarning(sonarRuntime, warnings::add);
              deprecationWarning.logNodeDeprecation(8);

The docs will also get updated to reflect this (see the pull request).

Point taken. But everyone and their sister has a different opinion on whether to fail early, or offer as much of the results possible and log a warning.

Hope this helps!