In JavaScript, don't suggest const for variables that are filled in subsequent .forEach loops with attribute accessors

[FlorianHoffmann]

Type
False Positive

Product

• Enterprise Edition
• Version 8.9.7 (build 52159)

Rule

• javascript:S3353
• Unchanged variables should be marked “const”

Message
‘oFeatures’ is never reassigned. Use ‘const’ instead.

Language
JavaScript

Example

const fnPrepareFeaturesModel = function(aFeatures) {
    let oFeatures = {}; // <== rule hits this
    aFeatures.forEach(function(oFeature) {
        oFeatures[oFeature.name] = oFeature.isActive; // <== variable *is* filled here
    });
    oFeaturesModel.setData(oFeatures);
};

[Colin]

Hey @FlorianHoffmann

Please read this thread regarding reporting false-positives:

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t…

(We’re missing what product you’re using and what version if applicable, and the precise Rule ID)

[FlorianHoffmann]

Hey Colin, sure thing. Actually did read it beforehand and thought I had everything together. Okay now?