IGNORE THIS THREAD Execution of pylint during analysis is deprecated but executable still requested

gabriel · November 25, 2019, 3:59pm

Sonarquabe EE 7.9 with SonarPython 1.14.1
PylintSensor throws exception and stops analysis:

[2019-11-19T19:23:10.596Z] 	at org.sonar.api.utils.command.CommandExecutor.execute(CommandExecutor.java:102)
[2019-11-19T19:23:10.596Z] 	at org.sonar.plugins.python.pylint.PylintArguments.pylintVersion(PylintArguments.java:45)
[2019-11-19T19:23:10.596Z] 	at org.sonar.plugins.python.pylint.PylintArguments.<init>(PylintArguments.java:37)
[2019-11-19T19:23:10.596Z] 	at org.sonar.plugins.python.pylint.PylintIssuesAnalyzer.<init>(PylintIssuesAnalyzer.java:46)
[2019-11-19T19:23:10.596Z] 	at org.sonar.plugins.python.pylint.PylintSensor.createAnalyzer(PylintSensor.java:105)
[2019-11-19T19:23:10.596Z] 	at org.sonar.plugins.python.pylint.PylintSensor.initializeAnalyzer(PylintSensor.java:95)
[2019-11-19T19:23:10.596Z] 	at org.sonar.plugins.python.pylint.PylintSensor.execute(PylintSensor.java:69)

Analysis still marked as successful
steps to reproduce: execute analysis with sonar.python.pylint.reportPath and make sure pylint binary is missing or not executable from PATH.

Even though execution of pylint during analysis is deprecated on all OSes, it appears Pylint remains executed when sonar.python.pylint.reportPath is set, just to get the version of pylint. See:

github.com

SonarSource/sonar-python/blob/d6340a4167d3f11f04471328f7030e2b0554908c/sonar-python-plugin/src/main/java/org/sonar/plugins/python/pylint/PylintSensor.java#L62


@Override
public void describe(SensorDescriptor descriptor) {
  descriptor
    .name("PylintSensor")
    .onlyOnLanguage(Python.KEY)
    .onlyOnFileType(InputFile.Type.MAIN)
    .createIssuesForRuleRepository(PylintRuleRepository.REPOSITORY_KEY);
}


boolean shouldExecute() {
  return !settings.get(PylintImportSensor.REPORT_PATH_KEY).isPresent();
}


@Override
public void execute(SensorContext sensorContext) {
  File workDir = new File(sensorContext.fileSystem().workDir(), "pylint");


  if (!shouldExecute() || !prepareWorkDir(workDir) || !initializeAnalyzer(sensorContext)) {
    return;
  }

github.com

SonarSource/sonar-python/blob/d6340a4167d3f11f04471328f7030e2b0554908c/sonar-python-plugin/src/main/java/org/sonar/plugins/python/pylint/PylintSensor.java#L69


}


boolean shouldExecute() {
  return !settings.get(PylintImportSensor.REPORT_PATH_KEY).isPresent();
}


@Override
public void execute(SensorContext sensorContext) {
  File workDir = new File(sensorContext.fileSystem().workDir(), "pylint");


  if (!shouldExecute() || !prepareWorkDir(workDir) || !initializeAnalyzer(sensorContext)) {
    return;
  }


  LOG.warn("Execution of pylint by SonarPython is deprecated and will be removed." +
    " Instead, pylint should be executed before sonar-scanner and its report should be imported using the '" + PylintImportSensor.REPORT_PATH_KEY + "' property.");


  int i = 0;
  FileSystem fileSystem = sensorContext.fileSystem();
  FilePredicates p = fileSystem.predicates();
  Iterable<InputFile> files = fileSystem.inputFiles(p.and(p.hasType(InputFile.Type.MAIN), p.hasLanguage(Python.KEY)));

github.com

SonarSource/sonar-python/blob/eed7b315b6116fe462a19c771013bf3891c92a97/sonar-python-plugin/src/main/java/org/sonar/plugins/python/pylint/PylintSensor.java#L99


}


private boolean initializeAnalyzer(SensorContext context) {
  try {
    String pylintConfigPath = conf.getPylintConfigPath(context.fileSystem());
    String pylintPath = conf.getPylintPath();
    analyzer = createAnalyzer(pylintConfigPath, pylintPath);
    return true;
  } catch (Exception e) {
    LOG.warn("Unable to use pylint for analysis. Error:", e);
    return false;
  }
}


// Visible for testing
PylintIssuesAnalyzer createAnalyzer(String pylintConfigPath, String pylintPath) {
  return new PylintIssuesAnalyzer(pylintPath, pylintConfigPath);
}


private void analyzeFile(SensorContext context, InputFile file, File out) throws IOException {
  FileSystem fileSystem = context.fileSystem();

gabriel · November 25, 2019, 4:01pm

My bad, I think I’ve been too fast in reading the code. This thread my be ignored.

Topic		Replies	Views
Pylint: thank you and goodbye Sonar Updates python , external_issues , pylint	0	1912	July 22, 2020
Is that possible to use pylint with SonarQube SonarQube Server / Community Build python	2	10695	May 26, 2020
Running pylint separately from sonar SonarQube Cloud scanner , python	4	1950	October 30, 2018
Pylint and sonarlint both find the same issue and display it twice SonarQube for IDE python , pylint , sonarqube-ide	3	1565	March 17, 2021
Sonar scanner cli for python projects SonarQube Server / Community Build	2	3741	March 11, 2020

IGNORE THIS THREAD Execution of pylint during analysis is deprecated but executable still requested

Related topics