How to start the scanner from now and not pick up all existing issues?

RCheesley · July 18, 2022, 10:11am

ALM used GitHub
CI system used GitHub Actions
Scanner command used when applicable see How to use SonarCloud with a forked repository on GitHub? - #34 by RCheesley
Languages of the repository PHP
Only if the SonarCloud project is public, the URL https://sonarcloud.io/summary/new_code?id=RCheesley_mautic&pullRequest=13
- And if you need help with pull request decoration, then the URL to the PR too Mautic sonar by RCheesley · Pull Request #13 · RCheesley/mautic · GitHub
Error observed Showing all problems for the whole codebase rather than just what the PR touches

Hi folks!

I am working on trying to implement Sonarcloud on our open source repo on GitHub.

I have been following the steps to get this working on a PR from a forked repo which is how we accept contributions - see How to use SonarCloud with a forked repository on GitHub? - #34 by RCheesley for the relevant files and steps I have taken this far.

I now have it working in that it’s running the checks and is pulling in the code coverage report from Codecov, however the report itself seems to be pulling up all the current issues with the whole codebase rather than just the things from the PR itself.

I am not sure if this is something that I have misconfigured in the settings and would appreciate a nudge in the right direction, as this is the last piece in the rather long-running puzzle that is getting SonarCloud deployed!

Thanks in advance!

Colin · July 18, 2022, 10:26am

Hey there.

I saw this in your GitHub actions logs:

INFO: SCM Publisher is disabled

This will prevent the detection of changed files / changed lines. I couldn’t find this setting in your repo – maybe you have it configured in the UI? Check your project-level Administration > General Settings > SCM

RCheesley · July 18, 2022, 10:33am

Thanks for the super speedy reply @Colin - just re-running against a PR with that setting turned on, sounds like that might be the missing link!

RCheesley · July 18, 2022, 10:59am

Hmm, it is still showing the same report:

github.com/RCheesley/mautic

Mautic sonar

RCheesley:4.x ← RCheesley:mauticSonar

opened 01:23PM - 13 May 22 UTC

RCheesley

+44 -2

| Q | A | -------------------------------------- | --- | Bug fix? (use the a.b branch) | [ ] | New feature/enhancement? (use the a.x branch) | [ ] | Deprecations? | [ ] | BC breaks? (use the c.x branch) | [ ] | Automated tests included? | [ ] | Related user documentation PR URL | mautic/mautic-documentation#... | Related developer documentation PR URL | mautic/developer-documentation#... | Issue(s) addressed | Fixes #...  #### Description:  #### Steps to test this PR:  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs [here](https://contribute.mautic.org/contributing-to-mautic/tester)) 2.

I checked and it looks like it should be enabled:

I tried also setting the provider as git but that made no difference - maybe I need to explicitly declare it in our properties file or in the command itself?

Update:

Still getting stuck here!

Set in the UI to be enabled, also set it in the project settings file:

github.com

RCheesley/mautic/blob/mauticSonar/sonar-project.properties#L7


      
          sonar.projectKey=RCheesley_mautic
          sonar.organization=rcheesley
          sonar.projectName=mautic
          sonar.projectVersion=1.0
          sonar.modules=phpmodule
          sonar.sourceEncoding=UTF-8
          sonar.scm.disabled=false
          sonar.scm.provider=git
          phpmodule.sonar.sources=app,plugins
          phpmodule.sonar.projectBaseDir=.
          phpmodule.sonar.inclusions=app/*.php,app/**/*.php,plugins/*.php,plugins/**/*.php
          phpmodule.sonar.exclusions=app/migrations/**/*,app/bundles/*Bundle/Config/**/*,app/bundles/*Bundle/DataFixtures/**/*,app/bundles/*Bundle/Tests/**/*,app/bundles/*Bundle/Translations/**/*,app/bundles/*Bundle/Views/**/*,app/middlewares/Test/**/*,app/bundles/CoreBundle/Test/**/*,plugins/*Bundle/Config/**/*,plugins/*Bundle/Tests/**/*,plugins/*Bundle/Translations/**/*,plugins/*Bundle/Views/**/*
          phpmodule.sonar.cpd.exclusions=**/*
          phpmodule.sonar.tests=tests
          sonar.php.coverage.reportPaths=clover.xml
          sonar.scm.disabled=true

When the action runs it is still showing that SCM is disabled:

Any ideas or anything obvious that I am missing here @Colin ?

Colin · July 18, 2022, 3:34pm

To be clear, you want sonar.scm.disabled to be set to false in all places – and a sonar-project.properties file will override anything set in the UI, so I would suggest removing it from your sonar-project.properties file and restoring your settings in the UI to the default.

RCheesley · July 18, 2022, 3:47pm

I believe it is set to false in all places - in the UI, in the project settings file (see screenshot above where it is not selected in the UI - assuming that to mean false and green to be true, as in, turn this on if you WANT to disable the sensor - and in the project settings file it is explicitly set to false).

Colin · July 18, 2022, 4:12pm

It’s set to true here:

github.com

RCheesley/mautic/blob/08063302d53719549179e4d3ab3e6331ecc32086/sonar-project.properties#L16


      
          sonar.sourceEncoding=UTF-8
          sonar.scm.disabled=false
          sonar.scm.provider=git
          phpmodule.sonar.sources=app,plugins
          phpmodule.sonar.projectBaseDir=.
          phpmodule.sonar.inclusions=app/*.php,app/**/*.php,plugins/*.php,plugins/**/*.php
          phpmodule.sonar.exclusions=app/migrations/**/*,app/bundles/*Bundle/Config/**/*,app/bundles/*Bundle/DataFixtures/**/*,app/bundles/*Bundle/Tests/**/*,app/bundles/*Bundle/Translations/**/*,app/bundles/*Bundle/Views/**/*,app/middlewares/Test/**/*,app/bundles/CoreBundle/Test/**/*,plugins/*Bundle/Config/**/*,plugins/*Bundle/Tests/**/*,plugins/*Bundle/Translations/**/*,plugins/*Bundle/Views/**/*
          phpmodule.sonar.cpd.exclusions=**/*
          phpmodule.sonar.tests=tests
          sonar.php.coverage.reportPaths=clover.xml
          sonar.scm.disabled=true

It looks like you may have accidentally declared the property twice in sonar-project.properties

RCheesley · July 18, 2022, 4:16pm

Ahhhhh, that would do it! Just removed that line, hopefully that will sort it out! Thanks for pointing out the mistake!

RCheesley · July 18, 2022, 4:59pm

That was it! Thanks!

system · July 25, 2022, 4:59pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.