FP for S6103 when using helper methods for assertions

Clean Code Report False-positive / False-negative...
1

If calling a static method in another class to create the consumer with the assertions the rule seems to fail to find them.

  • versions used 9.3.0
class ExampleTest {
	@Test
	void test6103() throws Exception {
		assertThatThrownBy(() -> {
			throw new IllegalArgumentException("Message");
		}).isInstanceOfSatisfying(IllegalArgumentException.class, hasMessage("Message"));  //No violation
	}

	@Test
	void test6103Outside() throws Exception {
		assertThatThrownBy(() -> {
			throw new IllegalArgumentException("Message");
		}).isInstanceOfSatisfying(IllegalArgumentException.class, IllegalArgumentExceptionAssertion.hasMessage("Message")); //FP?
	}

	public static Consumer<IllegalArgumentException> hasMessage(String message) {
		return e -> {
			AssertionsForClassTypes.assertThat(e.getMessage()).isEqualTo(message);
		};
	}
}

Where IllegalArgumentExceptionAssertion is a class containing the exact same static method ā€œhasMessageā€.

1 Like
5

Hello @fassen,

There are known limitations in some of our rules that prevent them from checking the code declared in other files.

Just to be sure that we are not missing anything: Do you still have the issue if you import hasMessage statically from IllegalArgumentExceptionAssertion?

6

Hi!

Having a static import of ā€œhasMessageā€ unfortunately made no difference.

7

Thanks for reporting the issue, a ticket has been created to get rid of this type of FP.

9

Thanks Dorian!

11

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.