FP for rule 1144 on methods referred my MethodSource with multiple references

[joaocotralha (João)]

Hi,

Similar to:

False positive for rule 1144 on method referred by JUnit's @MethodSource

Hi, as someone else already stated here: SonarQube marks function refered by MethodSource as Unused "private" method per rule 1144 - #20 by RPluizberto Sonarqube falsely marks a method as false positive if it is a method source for a JUnit Test which uses @MethodSource without a value (which means that the method has the same name as the test method). We’re using SonarQube 10.5.1.90531.

SonarQube marks function refered by MethodSource as Unused "private" method per rule 1144

UsingSonarQube Enterprise Edition Version 8.9.7 (build 52159) I am trying to use the new MethodSource functionality from Junit 5, but SonarQube marks the referenced function as an unused private method. As far as I can see, SonarQube should support Junit 5, so I don’t know why it flags these functions as unused.

But the FP is presented only when using MethodSource with multiple argument syntax

Example:

private static Stream<Arguments> getArguments() {
  return Stream.of(
    Arguments.of("arg")
  )
}

@MethodSource({"getArguments"})
void testAndAssert() {}

The above code will trigger rule 1144 on function getArguments() definition. This only happens if “getArguments” in MethodSource is between {}. If instead we do:

@MethodSource("getArguments")

There’s no issue, as per Jira

[Dorian_Burihabwa]

Hi @joaocotralha,
Welcome to the community!

Thank you for the thorough report; I have created this ticket to fix the issue.

Cheers,

Dorian