FP C++ / S6018: static local variable & inline

Rules and Languages Report False-positive / False-negative...
1

Hello,

I use SonarQube for Visual Studio 9.9.0.16495 for C++17 code, and get the S6018 issue for this code (line with static):

std::vector<LogContext>& ProcessEventsScope::Stack()
{
    static thread_local std::vector<LogContext> stack;
    return stack;
}

inline is useless here: local variable → no external linking → no potential multiple definitions

[for definition of LogContext, see my other message posted today]

4

Hi @Oodini,

While well-intended, this rule led to many controversial cases where using an inline variable brought no benefit, or simply was not appropriate, so we decided to deprecate it, with the intent of removing it as soon as our deprecation policy allows.