Hello,
I think there might be a bug in SonarSource. I think adding
switch (myEnum) { // Compliant
case A, B:
case C:
break;
}
to java-checks-test-sources/src/main/java/checks/SwitchLastCaseIsDefaultCheck.java should by compliant. Perhaps the fix is altering java-checks/src/main/java/org/sonar/java/checks/SwitchLastCaseIsDefaultCheck.java to
/*
* SonarQube Java
* Copyright (C) 2012-2022 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.java.checks;
import java.util.Collections;
import java.util.List;
import java.util.stream.Stream;
import org.sonar.check.Rule;
import org.sonar.java.ast.api.JavaKeyword;
import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
import org.sonar.plugins.java.api.semantic.Symbol;
import org.sonar.plugins.java.api.tree.CaseLabelTree;
import org.sonar.plugins.java.api.tree.ExpressionTree;
import org.sonar.plugins.java.api.tree.SwitchStatementTree;
import org.sonar.plugins.java.api.tree.Tree;
import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
@DeprecatedRuleKey(ruleKey = "SwitchLastCaseIsDefaultCheck", repositoryKey = "squid")
@Rule(key = "S131")
public class SwitchLastCaseIsDefaultCheck extends IssuableSubscriptionVisitor {
@Override
public List<Tree.Kind> nodesToVisit() {
return Collections.singletonList(Tree.Kind.SWITCH_STATEMENT);
}
@Override
public void visitNode(Tree tree) {
SwitchStatementTree switchStatementTree = (SwitchStatementTree) tree;
if (getDefaultLabel(switchStatementTree)) {
if (!isSwitchOnEnum(switchStatementTree)) {
reportIssue(switchStatementTree.switchKeyword(), "Add a default case to this switch.");
} else if (missingCasesOfEnum(switchStatementTree)) {
reportIssue(switchStatementTree.switchKeyword(), "Complete cases by adding the missing enum constants or add a default case to this switch.");
}
}
}
private static boolean getDefaultLabel(SwitchStatementTree switchStatementTree) {
return allCases(switchStatementTree).noneMatch(SwitchLastCaseIsDefaultCheck::isDefault);
}
private static boolean isDefault(CaseLabelTree caseLabelTree) {
return JavaKeyword.DEFAULT.getValue().equals(caseLabelTree.caseOrDefaultKeyword().text());
}
private static boolean isSwitchOnEnum(SwitchStatementTree switchStatementTree) {
Symbol.TypeSymbol symbol = switchStatementTree.expression().symbolType().symbol();
return symbol.isEnum() || symbol.isUnknown();
}
private static boolean missingCasesOfEnum(SwitchStatementTree switchStatementTree) {
return numberConstants(switchStatementTree) > allConstants(switchStatementTree).count();
}
private static Stream<CaseLabelTree> allCases(SwitchStatementTree switchStatementTree) {
return switchStatementTree.cases().stream().flatMap(caseGroup -> caseGroup.labels().stream());
}
private static long numberConstants(SwitchStatementTree switchStatementTree) {
return switchStatementTree.expression().symbolType().symbol().memberSymbols().stream()
.filter(Symbol::isVariableSymbol)
.filter(Symbol::isEnum)
.count();
}
private static Stream<ExpressionTree> allConstants(SwitchStatementTree switchStatementTree) {
return allCases(switchStatementTree).flatMap(caseLabelTree -> caseLabelTree.expressions().stream());
}
}