False Positive on "Promises should not be misused (typescript:S6544)" Rule

[iurynathan]

Operating system: Windows 11 with WSL running Ubuntu 22.04 LTS
IDE: Visual Studio Code

Hello,

I’ve been encountering an issue with SonarLint while working on a React project, specifically in a form submission handler. The SonarLint TypeScript rule “Promises should not be misused (typescript:S6544)” is flagging a piece of code that seems to handle Promises correctly.

Here’s the function causing the warning:

async function handleSubmitForm(e: React.FormEvent) {
  e.preventDefault();

  // Validate Data
  if (!formData.email || !formData.password) {
    toast.error('Please check the fields!');
    return;
  }

  try {
    await handleLogin(formData, selectedProfile);
  } catch (error) {
    toast.error('An error occurred during login!');
  }
}

The form event handler function (handleSubmitForm ) is async and properly uses try/catch to handle any errors that might be thrown from the handleLogin function. The handleLogin function is defined elsewhere and is a Promise-based function:

(local function) handleLogin(payload: ClientFormLogin, role: IClient['role']): Promise<boolean>

The warning appears at the point where the handleSubmitForm function is passed to the form’s onSubmit event:

<form onSubmit={handleSubmitForm}>

I’m not clear why SonarLint is flagging this as a misuse of Promises. Based on my understanding, I’m using await correctly within a try/catch block, which should properly handle the Promise returned by handleLogin. Any insights or help to understand this issue would be greatly appreciated.

Thank you for your time.

[ilia]

Hello Iury,

Indeed the try/catch you are using would take care of the issue.

We’ve recently updated the rule to not flag JSX attributes. Could you provide a more complete code example so we can reproduce it?

Best,
Ilia

[asfaltboy (Pavel Savchenko)]

We’re getting S6544 on TSX files … is this a regression, or was the fix not applied to TSX files?

also see previously locked issue here:

Promise-returning function provided to attribute where a void return was expected

In the new update of SonarQube that includes the TypeScript rule S6544, the following error has emerged in my code: “Promise-returning function provided to attribute where a void return was expected”. I have already verified that the function is not a promise, but the error persists. Has anyone experienced the same or a similar error? I am using the React Hook Form library for form handling. import React from "react"; import { useForm, SubmitHandler } from "react-hook-form"; type FormValues = …

[gab (Gabriel Vivas)]

Hi Pavel,

You are posting on a 1-year-old thread.

Could you please open a new one and share some details about the problem you are seeing (e.g., what product are you using, perhaps a small reproducer)?