False positive - Null on at least one execution path

snakefoot · October 20, 2022, 6:06pm

Must-share information (formatted with Markdown):

which versions are you using ? (SonarCloud)
what are you trying to achieve ? (Fix source code scanner)
what have you tried so far to achieve this (Creating issue)

https://sonarcloud.io/project/issues?resolved=false&types=BUG&branch=dev&id=nlog2&open=AYP2NU0SZinl2h1ztXSa

Pavel_Mikula · November 8, 2022, 10:36am

Hi,

This issue has already been created to fix the problem:

github.com/SonarSource/sonar-dotnet

Fix S2259 FP: `is null` check on generic type

opened 06:52PM - 24 Oct 22 UTC

snakefoot

Area: CFG/SE Area: VB.NET Area: C# Type: CFG/SE FPs

### Description S2259 - is null on at least one execution path ### Repro s…teps ```c# public static ReadOnlySingleBucketDictionary<TKey, IList<TValue>> BucketSort<TValue, TKey>(this IList<TValue> inputs, KeySelector<TValue, TKey> keySelector, IEqualityComparer<TKey> keyComparer) { Dictionary<TKey, IList<TValue>> buckets = null; TKey singleBucketKey = default(TKey); for (int i = 0; i < inputs.Count; i++) { TKey keyValue = keySelector(inputs[i]); if (i == 0) { singleBucketKey = keyValue; } else if (buckets is null) { if (!keyComparer.Equals(singleBucketKey, keyValue)) { // Multiple buckets needed, allocate full dictionary buckets = CreateBucketDictionaryWithValue(inputs, keyComparer, i, singleBucketKey, keyValue); } } else { if (!buckets.TryGetValue(keyValue, out var eventsInBucket)) // BUG S2259 - 'buckets' is null on at least one execution path { eventsInBucket = new List<TValue>(); buckets.Add(keyValue, eventsInBucket); } eventsInBucket.Add(inputs[i]); } } if (buckets is null) return new ReadOnlySingleBucketDictionary<TKey, IList<TValue>>(new KeyValuePair<TKey, IList<TValue>>(singleBucketKey, inputs), keyComparer); else return new ReadOnlySingleBucketDictionary<TKey, IList<TValue>>(buckets, keyComparer); } ``` ### Expected behavior Not reported as bug ### Actual behavior Reported as bug ### Known workarounds Rewrite code ### Related information https://sonarcloud.io/project/issues?resolved=false&types=BUG&branch=dev&id=nlog2&open=AYP2NU0SZinl2h1ztXSa

system · November 15, 2022, 10:37am

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.