False positive for 'switch case clauses should not have too many lines of code'

[sithmein (Thorsten Meinl)]

I believe this screen shot says it all: the case has four lines only but Sonar claims it has six.

I believe it gets confused by switch blocks where the opening and closing brackets are also counted as code lines.

[Colin]

I’ve moved your post to the category for reporting false-positives.

How to Report a False-positive / False-negative

Hey SonarSource Community! False-positives happen, as do false-negatives, and we’re eager to fix them. We are thrilled when our users report problems, so we can make our products better. What is a false-positive (FP)? A false-positive is when an issue is raised unexpectedly on code that should not trigger an issue, or where the suggested action doesn’t make any sense for the code. What is a false-negative (FN)? A false-negative is when an issue should be raised on a piece of code, but isn’t…

Can you please update your post with the information requested in the post above? Specifically the rule ID, and a text based sample of code (no screenshots).

[sithmein (Thorsten Meinl)]

Here’s a snippet that causes a false-positive for java:S1151:

            switch (op.toLowerCase(Locale.US)) {
                case "add" -> {
                    if (user == null) {
                        throw new SCIMException(400, "User  does not exist.");
                    }
                    user.addGroup(group);
                }
                case "remove" -> {
                    if (user != null) {
                        user.removeGroup(group);
                    }
                }
                default -> throw new SCIMException(400, "Patch operation  is not allowed for members");
            }

[irina.batinic]

Hi @sithmein,

After testing and some investigation, this is indeed a FP.
I created a ticket for it and you can track progress here: [SONARJAVA-4919] - Jira

All the best,

Irina