-
What language is this for?
- Java
-
Which rule?
- S3516
-
Why do you believe it’s a false-positive/false-negative?
- The message is saying that the method always returns the same value. But if you look at the code I provided, when the argument is not null, it will return a different value than when it’s null.
-
Are you using
- SonarLint - Intellij 2023.3.3 with SonarLint plugin 10.2.1.77304 connected to SonarCloud
-
How can we reproduce the problem? Give us a self-contained snippet of code (formatted text, no screenshots)
public static Date toUtilDate(LocalDate localDate)
{
if (localDate == null)
{
return null;
}
ZonedDateTime atStartOfDay = localDate.atStartOfDay(ZoneId.of("Europe/Amsterdam"));
Instant instant = atStartOfDay.toInstant();
return Date.from(instant);
}
public static LocalDateTime toLocalDateTime(Date utilDate)
{
if (utilDate == null)
{
return null;
}
if (utilDate instanceof java.sql.Timestamp)
{
return ((java.sql.Timestamp) utilDate).toLocalDateTime(); // toInstant van java.sql.Timestamp is unsupported
}
if (utilDate instanceof java.sql.Date)
{
return ((java.sql.Date) utilDate).toLocalDate().atStartOfDay(); // toInstant van java.sql.Date is unsupported
}
return LocalDateTime.ofInstant(utilDate.toInstant(), SCREENIT_DEFAULT_ZONE);
}
// this method throws the SonarLint warning
public static Date startDag(Date date)
{
if (date == null)
{
return null;
}
return toUtilDate(toLocalDate(date).atStartOfDay());
}
When date == null, the method will return null, but when date == Date, it will return the start of that day using two conversions, first to LocalDate and then back to Date again. Both utility methods have the null check.