False positive for php:S125 - commented out code

Rules and Languages Report False-positive / False-negative...
, ,
1

The current version of the VSCode Sonarlint plugin (v1.17.0) produces a false positive error. It detects the second line in the following comment wrongly as commented out code:

			// Regarding $mode in recursive calls:
			// * self is a must to have the fallback item itself included;
			// * respect the original caller about whether to include variants or not;
			// * others should be excluded as they'll be handled here in loops.
2

Hello @micgro42 ,
thank you very much for your feedback.

I have verified your example. We will now look at how we can avoid such false positives.
I will come back to you when we have decided on further steps.

Best,
Nils

1 Like
3

Hi @micgro42,

we decide to revise the implementation of the rule to reduce the false positive noise to a minimum.
I have created the ticket SONARPHP-1028, so you can be up to date. Thanks again for your report. We will announce it also here when the problem is resolved.

Best,
Nils

1 Like
4

Thank you for looking into this, I really appreciate it! :slight_smile:

5

It has been released in SonarLint VSCode 1.18 (https://jira.sonarsource.com/browse/SLVSCODE-149)

1 Like
6

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.